Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knightos-patchrom: init at 1.1.3 #99274

Merged
merged 1 commit into from Oct 2, 2020
Merged

knightos-patchrom: init at 1.1.3 #99274

merged 1 commit into from Oct 2, 2020

Conversation

@siraben
Copy link
Member

@siraben siraben commented Oct 1, 2020

Motivation for this change

knightos-patchrom: init at 1.1.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 2, 2020

Result of nixpkgs-review pr 99274 1

1 package built:
  • knightos-patchrom

Copy link
Contributor

@doronbehar doronbehar left a comment

Passes nixpkgs-review build and --help test.

@doronbehar doronbehar merged commit 6bb90a2 into NixOS:master Oct 2, 2020
19 checks passed
@siraben siraben deleted the patchrom-init branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants