Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teams: remove rect-overlay -- causes desktop sharing to break without a composer #99279

Closed
wants to merge 1 commit into from

Conversation

@umazalakain
Copy link
Contributor

@umazalakain umazalakain commented Oct 1, 2020

Motivation for this change

Screen sharing on Teams is currently broken unless the user is using a composer (not that common across NixOS users).
This rect-overlay draws a rectangular red border around the screen, indicating that a recording is in process.
Removing the file makes screen sharing work.

I am not sure if we want to include this small hack in nixpkgs, but even if this PR is closed it might still be useful as a reference for Teams users.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 1, 2020

If we include such a hack a comment in the package would go a long way.

Also please recheck https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md, specifically with regard to commit messages.

@umazalakain
Copy link
Contributor Author

@umazalakain umazalakain commented Oct 1, 2020

@mweinelt thanks for the review, how does that look?

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 1, 2020

The comment reads nicely, you can move it just above the rm statement.

Please note, I cannot decide if this change goes in, that should be the maintainers decision.

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 1, 2020

Yes please! This has been crippling for me the past week or two 😱

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 1, 2020

@jonringer has this been biting you too?

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 1, 2020

Yes please! This has been crippling for me the past week or two scream

I wish this issue was biting me. But on sway teams just collapses in on itself when I want to start sharing my screen. I wonder if this is related.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 1, 2020

I've noticed it too, and I was just using chromium + web.

@liff
Copy link
Contributor

@liff liff commented Oct 3, 2020

This looks like the relevant upstream bug report, right? So for a proper fix we are waiting for upstream.

For the users that are running a compositor, who currently do not have this issue, this change would cause the red border not to appear when screen sharing is active?

Perhaps this could be something that could be conditionally enabled via an argument to the derivation so that the feature could be kept if it is working properly.

An altenative solution, I suppose, could be to wrap rect-overlay with something that detects whether a compositor is running and just exits if not.

@liff
Copy link
Contributor

@liff liff commented Dec 8, 2020

The same workaround was committed in 1489c07.

@liff liff closed this Dec 8, 2020
liff added a commit to liff/nixpkgs that referenced this issue Jun 8, 2021
The rect-overlay doesn’t work on non-composited window managers
such as i3 but it’s not a problem for others. Make the choice
available via an argument to the derivation.

The setting defaults to `false` so that it works for a broader
set of users.

See also: NixOS#99279.
peterhoeg added a commit to peterhoeg/nixpkgs that referenced this issue Jun 15, 2021
The rect-overlay doesn’t work on non-composited window managers
such as i3 but it’s not a problem for others. Make the choice
available via an argument to the derivation.

The setting defaults to `false` so that it works for a broader
set of users.

See also: NixOS#99279.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants