Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knightos-genkfs: init at 1.3.2 #99283

Merged
merged 1 commit into from Nov 26, 2020
Merged

knightos-genkfs: init at 1.3.2 #99283

merged 1 commit into from Nov 26, 2020

Conversation

@siraben
Copy link
Member

@siraben siraben commented Oct 1, 2020

Motivation for this change

knightos-genkfs: init at 1.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/development/tools/knightos/genkfs/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/knightos/genkfs/default.nix Outdated Show resolved Hide resolved
@danieldk
Copy link
Member

@danieldk danieldk commented Nov 17, 2020

The build fails with:

builder for '/nix/store/2c6wwckmx7qkwsi4v37firh0rnbpfw8h-genkfs-1.3.2.drv' failed with exit code 2; last 10 log lines:
  Scanning dependencies of target genkfs
  Scanning dependencies of target man
  [ 50%] Building C object CMakeFiles/genkfs.dir/main.c.o
  a2x: WARNING: --destination-dir option is only applicable to HTML based outputs
  [100%] Linking C executable genkfs
  [100%] Built target genkfs
  a2x: ERROR: "xsltproc"  --stringparam callout.graphics 0 --stringparam navig.graphics 0 --stringparam admon.textlabel 1 --stringparam admon.graphics 0  "/nix/store/dm7a9x955m7lbxzx52s2fq0j57kal39c-asciidoc-8.6.9/etc/asciidoc/docbook-xsl/manpage.xsl" "/build/source/build/genkfs.1.xml" returned non-zero exit status 5
  make[2]: *** [CMakeFiles/man.dir/build.make:76: man] Error 1
  make[1]: *** [CMakeFiles/Makefile2:97: CMakeFiles/man.dir/all] Error 2
  make: *** [Makefile:149: all] Error 2

@siraben
Copy link
Member Author

@siraben siraben commented Nov 17, 2020

Thanks. Will look into this.

@siraben
Copy link
Member Author

@siraben siraben commented Nov 22, 2020

Result of nixpkgs-review pr 99283 1

1 package built:
  • knightos-genkfs

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 99283 run on x86_64-linux 1

1 package built:
  • knightos-genkfs

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 99283 run on x86_64-darwin 1

1 package built:
  • knightos-genkfs

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 99283 run on x86_64-darwin 1

1 package built:
  • knightos-genkfs

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 99283 run on x86_64-linux 1

1 package built:
  • knightos-genkfs

@SuperSandro2000 SuperSandro2000 merged commit e56bfa4 into NixOS:master Nov 26, 2020
19 checks passed
@siraben siraben deleted the genkfs-init branch Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants