Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knightos-z80e: init at 0.5.0 #99288

Merged
merged 1 commit into from Oct 17, 2020
Merged

knightos-z80e: init at 0.5.0 #99288

merged 1 commit into from Oct 17, 2020

Conversation

@siraben
Copy link
Member

@siraben siraben commented Oct 1, 2020

Motivation for this change

knightos-z80e: init at 0.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/development/tools/knightos/z80e/default.nix Outdated Show resolved Hide resolved
@danieldk
Copy link
Member

@danieldk danieldk commented Oct 16, 2020

BTW, feel free to ping me in the future if any KnightOS package PRs go stale.

@danieldk
Copy link
Member

@danieldk danieldk commented Oct 17, 2020

Pushed a change that also puts knightos-scas in nativeBuildInputs plus some small formatting changes.

Copy link
Member

@danieldk danieldk left a comment

LGTM

Result of nixpkgs-review pr 99288 1

1 package built:
  • knightos-z80e

@danieldk danieldk merged commit cd0e1c0 into NixOS:master Oct 17, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd09a9e"; rev="bd09a9e3864d4a482c3d6dca5731286914600e57"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd09a9e"; rev="bd09a9e3864d4a482c3d6dca5731286914600e57"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd09a9e"; rev="bd09a9e3864d4a482c3d6dca5731286914600e57"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd09a9e"; rev="bd09a9e3864d4a482c3d6dca5731286914600e57"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd09a9e"; rev="bd09a9e3864d4a482c3d6dca5731286914600e57"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd09a9e"; rev="bd09a9e3864d4a482c3d6dca5731286914600e57"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd09a9e"; rev="bd09a9e3864d4a482c3d6dca5731286914600e57"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
knightos-z80e, knightos-z80e.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
knightos-z80e, knightos-z80e.passthru.tests on x86_64-linux Success
Details
@siraben siraben deleted the z80e-init branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants