Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zncModules.clientbuffer: 2015-08-27 -> 2020-04-24 #99289

Merged
merged 2 commits into from Oct 2, 2020

Conversation

@szlend
Copy link
Contributor

@szlend szlend commented Oct 1, 2020

Motivation for this change

The original clientbuffer ZNC module has been abandoned since 2015. It has been picked up and maintained as a fork by another maintainer (https://github.com/CyberShadow/znc-clientbuffer).

This is now the recommended repo by the ZNC wiki page (https://wiki.znc.in/Clientbuffer)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@szlend
Copy link
Contributor Author

@szlend szlend commented Oct 1, 2020

CC @hrdinka (maintainer)

@szlend szlend changed the title zncModules.clientbuffer: Update from 2015-08-27 to 2020-10-01 zncModules.clientbuffer: 2015-08-27 -> 2020-10-01 Oct 1, 2020
@szlend szlend force-pushed the szlend:znc-clientbuffer branch from 0811da3 to cf69190 Oct 2, 2020
@hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Oct 2, 2020

@ofborg eval

@hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Oct 2, 2020

@szlend I just noticed that you are a first time contributor. Thanks for the update, your work and welcome on board!

In case you plan to stick around longer and make more contributions in the future, you can think about adding yourself as a maintainer for this derivation. More about this here https://nixos.wiki/wiki/Nixpkgs#Becoming_a_Nixpkgs_maintainer

Have a nice day, Christoph

@szlend
Copy link
Contributor Author

@szlend szlend commented Oct 2, 2020

@hrdinka Thank you, I would gladly help maintain this derivation. I'll go ahead and add myself to the maintainers. I already tried doing so but I reverted it after a failed build. Reading through it now, it looks as I forgot to add myself to the maintainers-list.nix.

@szlend szlend force-pushed the szlend:znc-clientbuffer branch from cf69190 to 6084bd6 Oct 2, 2020
@szlend szlend changed the title zncModules.clientbuffer: 2015-08-27 -> 2020-10-01 zncModules.clientbuffer: 2015-08-27 -> 2020-04-24 Oct 2, 2020
@hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Oct 2, 2020

Yes, that was definitely the problem. Just add another commit to this pull request and make sure to name both correct regarding https://nixos.org/manual/nixpkgs/stable/#chap-submitting-changes

The actual commit containing the update should be name zncModules.clientbuffer: 2015-08-27 -> 2020-04-24
and the first commit maintainers: add szlend. This way we keep our commit history nice and tidy :) Gits interactive rebase git rebase -i … comes in handy for such jobs.

@szlend szlend force-pushed the szlend:znc-clientbuffer branch from 6084bd6 to 41f6274 Oct 2, 2020
@hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Oct 2, 2020

Great 👍 welcome on board!

Now lets wait for OfBorg to finish.

@szlend
Copy link
Contributor Author

@szlend szlend commented Oct 2, 2020

Thanks for the help @hrdinka. Should be good to go now :)

@hrdinka hrdinka merged commit 9815a6d into NixOS:master Oct 2, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
zncModules.clientbuffer, zncModules.clientbuffer.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="41f6274"; rev="41f6274c34c1d21c7dd5345f4a5113c8c0160483"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="41f6274"; rev="41f6274c34c1d21c7dd5345f4a5113c8c0160483"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="41f6274"; rev="41f6274c34c1d21c7dd5345f4a5113c8c0160483"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="41f6274"; rev="41f6274c34c1d21c7dd5345f4a5113c8c0160483"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="41f6274"; rev="41f6274c34c1d21c7dd5345f4a5113c8c0160483"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="41f6274"; rev="41f6274c34c1d21c7dd5345f4a5113c8c0160483"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="41f6274"; rev="41f6274c34c1d21c7dd5345f4a5113c8c0160483"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zncModules.clientbuffer, zncModules.clientbuffer.passthru.tests on x86_64-linux Success
Details
@hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Oct 2, 2020

Thanks for the changes and congrats to your first NixOS contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.