Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpexs: init at 11.3.0 #99294

Merged
merged 1 commit into from Oct 2, 2020
Merged

jpexs: init at 11.3.0 #99294

merged 1 commit into from Oct 2, 2020

Conversation

@samuelgrf
Copy link
Contributor

@samuelgrf samuelgrf commented Oct 1, 2020

Motivation for this change

I use this for removing copy protection from Flash games/animations, so they can be archived and played offline.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/development/tools/jpexs/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/jpexs/default.nix Show resolved Hide resolved
@samuelgrf samuelgrf force-pushed the samuelgrf:initpkg/jpexs branch from f7354ac to afa5fba Oct 2, 2020
@samuelgrf samuelgrf requested a review from doronbehar Oct 2, 2020
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 2, 2020

Result of nixpkgs-review pr 99294 1

1 package built:
  • jpexs
Copy link
Contributor

@doronbehar doronbehar left a comment

Passes nixpkgs-review build and --help test.

@doronbehar doronbehar merged commit 6488d44 into NixOS:master Oct 2, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.