Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgxg: Init at 0.1.2 #99302

Closed
wants to merge 3 commits into from
Closed

rgxg: Init at 0.1.2 #99302

wants to merge 3 commits into from

Conversation

@hloeffler
Copy link
Contributor

@hloeffler hloeffler commented Oct 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@doronbehar doronbehar left a comment

Also, your PR should have eventually two commits:

maintainers: add <me>
<package-name>: init at <version>
pkgs/tools/text/rgxg/default.nix Show resolved Hide resolved
doInstallCheck = true;
installCheckTarget = "check";
Comment on lines +14 to +15

This comment has been minimized.

@doronbehar

doronbehar Oct 2, 2020
Contributor

What's wrong with regular doCheck and checkTarget?

This comment has been minimized.

@hloeffler

hloeffler Oct 2, 2020
Author Contributor

nothing,
i don't understand everything yet, this was copied from an other package, and i was just happy that it worked

This comment has been minimized.

@doronbehar

doronbehar Oct 2, 2020
Contributor

I see you are new :) Welcome aboard. I don't know where you borrowed that from, but it's considered more common to use doCheck = true. check is the default check (make) target for doCheck, so you should spare yourself 1 line of from the expression. For more info, refer to https://nixos.org/nixpkgs/manual/#chap-stdenv .

This comment has been minimized.

@hloeffler

hloeffler Oct 2, 2020
Author Contributor

I don't know how to edit my commits here, so i created a new pr with 2 commits:
#99422

Thanks for the weclome

pkgs/tools/text/rgxg/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/rgxg/default.nix Outdated Show resolved Hide resolved
hloeffler and others added 2 commits Oct 2, 2020
Co-authored-by: Doron Behar <doron.behar@gmail.com>
Co-authored-by: Doron Behar <doron.behar@gmail.com>
@hloeffler
Copy link
Contributor Author

@hloeffler hloeffler commented Oct 2, 2020

Thank you for your time and feedback,
i will find out how to do it

@hloeffler
Copy link
Contributor Author

@hloeffler hloeffler commented Oct 2, 2020

i created a new one: #99422

@hloeffler hloeffler closed this Oct 2, 2020
@hloeffler hloeffler deleted the hloeffler:rgxg-init branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.