Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrbk: 0.29.1 -> 0.31.3 #99303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

btrbk: 0.29.1 -> 0.31.3 #99303

wants to merge 1 commit into from

Conversation

@woffs
Copy link
Contributor

@woffs woffs commented Oct 1, 2020

Motivation for this change
  • new: lsbtr
  • work around non-working --argv0 when wrapping perl or shell scripts
  • add updateScript
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@asymmetric asymmetric left a comment

Thanks!

pkgs/tools/backup/btrbk/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from asymmetric Oct 31, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 99303 run on x86_64-linux 1

1 package built:
  • btrbk

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 99303 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • btrbk

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

@woffs Can you solve the merge conflict?

@woffs
Copy link
Contributor Author

@woffs woffs commented Nov 26, 2020

@woffs Can you solve the merge conflict?

done.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 28, 2020

Result of nixpkgs-review pr 99303 run on x86_64-linux 1

1 package built:
  • btrbk

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

@asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Dec 28, 2020

It's gpl3Only.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 29, 2020

Result of nixpkgs-review pr 99303 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • btrbk

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Please fix the merge conflict.

pkgs/tools/backup/btrbk/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@asymmetric asymmetric left a comment

0.31.0 was released

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 21, 2021

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99303 run on x86_64-linux 1

1 package built:
  • btrbk

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

btrbk:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern '/etc' doesn't match anything in file './doc/Makefile'
substituteStream(): WARNING: pattern '/bin/date' doesn't match anything in file 'contrib/cron/btrbk-mail'
substituteStream(): WARNING: pattern '/bin/echo' doesn't match anything in file 'contrib/cron/btrbk-mail'

Please check the offending substituteInPlace for typos or changes in source.

@woffs woffs changed the title btrbk: 0.29.1 -> 0.30.0 btrbk: 0.29.1 -> 0.31.0 Jan 21, 2021
@ofborg ofborg bot requested a review from asymmetric Jan 21, 2021
@woffs woffs changed the title btrbk: 0.29.1 -> 0.31.0 btrbk: 0.29.1 -> 0.31.1 Mar 19, 2021
@stale
Copy link

@stale stale bot commented Sep 19, 2021

I marked this as stale due to inactivity. → More info

- add updateScript
- work around non-working --argv0 when wrapping perl or shell scripts
- change license to gpl3Only
@stale stale bot removed the 2.status: stale label Sep 21, 2021
@woffs woffs changed the title btrbk: 0.29.1 -> 0.31.1 btrbk: 0.29.1 -> 0.31.3 Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants