Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatresize: 1.0.2 -> 1.1.0 #99306

Merged
merged 1 commit into from Oct 30, 2020
Merged

fatresize: 1.0.2 -> 1.1.0 #99306

merged 1 commit into from Oct 30, 2020

Conversation

@puckipedia
Copy link
Contributor

@puckipedia puckipedia commented Oct 1, 2020

Motivation for this change

New releases :P

Author is the same, they just moved from SF to GitHub.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 1, 2020

changelog for reference.

@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 1, 2020

The commit says 1.1.1, but it's actually 1.1.0 in the package, which is correct.

The software actually reports fatresize 1.0.3 (19800101) when run, but that's probably an upstream issue.

@puckipedia puckipedia changed the title fatresize: 1.0.2 -> 1.1.1 fatresize: 1.0.2 -> 1.1.0 Oct 2, 2020
@puckipedia
Copy link
Contributor Author

@puckipedia puckipedia commented Oct 2, 2020

woops, my mistake

ajs124
ajs124 approved these changes Oct 2, 2020
@bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 30, 2020

Result of nixpkgs-review pr 99306 1

1 package built:
- fatresize

@bhipple bhipple merged commit 4230320 into NixOS:master Oct 30, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
fatresize, fatresize.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
fatresize, fatresize.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3733a49"; rev="3733a496bd6b6805c55198c60fb3ddbd8e59b2e4"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3733a49"; rev="3733a496bd6b6805c55198c60fb3ddbd8e59b2e4"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3733a49"; rev="3733a496bd6b6805c55198c60fb3ddbd8e59b2e4"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3733a49"; rev="3733a496bd6b6805c55198c60fb3ddbd8e59b2e4"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3733a49"; rev="3733a496bd6b6805c55198c60fb3ddbd8e59b2e4"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3733a49"; rev="3733a496bd6b6805c55198c60fb3ddbd8e59b2e4"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3733a49"; rev="3733a496bd6b6805c55198c60fb3ddbd8e59b2e4"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants