Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabnine: fix build #99310

Merged
merged 1 commit into from Oct 1, 2020
Merged

tabnine: fix build #99310

merged 1 commit into from Oct 1, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 1, 2020

Motivation for this change

followup to #99264

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
mkdir -p $out/bin
ln -s $src $out/bin/TabNine
cp -r $src $out/bin/TabNine
Copy link
Contributor

@onsails onsails Oct 1, 2020

$src here is a single binary, why cp -r?

Copy link
Contributor Author

@jonringer jonringer Oct 1, 2020

$src is another store path, thus it's read-only.

The build fails to do chmod

@onsails
Copy link
Contributor

@onsails onsails commented Oct 1, 2020

sorry for messing this up
#99312

Co-authored by: @onsails
@jonringer jonringer mentioned this pull request Oct 1, 2020
10 tasks
@jonringer jonringer merged commit e6ec27b into NixOS:master Oct 1, 2020
2 of 3 checks passed
@jonringer jonringer deleted the fix-tabnine branch Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants