Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msglint: init at 1.04 #99319

Closed
wants to merge 1 commit into from
Closed

msglint: init at 1.04 #99319

wants to merge 1 commit into from

Conversation

@apeyroux
Copy link
Member

@apeyroux apeyroux commented Oct 1, 2020

Motivation for this change

init msglint

! I don't understand the license the developer wanted to use !

(C) Copyright 1991-1997,2002 by Chris Newman
All Rights Reserved.

Permission to use, copy, modify, distribute, and sell this software
and its documentation for any purpose is hereby granted without fee,
provided that the above copyright notice appear in all copies, and
that the name of Chris Newman not be used in advertising or publicity
pertaining to distribution of the software without specific, written
prior permission.  Chris Newman makes no representations about the
suitability of this software for any purpose.  It is provided "as is"
without express or implied warranty.

CHRIS NEWMAN DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO
EVENT SHALL CHRIS NEWMAN BE LIABLE FOR ANY SPECIAL, INDIRECT OR
CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF
USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
PERFORMANCE OF THIS SOFTWARE.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@oxzi oxzi left a comment

Thanks for this PR. The license looks like the MIT one for me.

pkgs/applications/misc/msglint/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/msglint/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/msglint/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/msglint/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/msglint/default.nix Outdated Show resolved Hide resolved
@apeyroux
Copy link
Member Author

@apeyroux apeyroux commented Oct 2, 2020

@oxzi thx for your review

Copy link
Member

@oxzi oxzi left a comment

Thanks for quickly adapting the proposed changes. Here are two more little things.

pkgs/applications/misc/msglint/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/msglint/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/msglint/default.nix Outdated Show resolved Hide resolved
oxzi
oxzi approved these changes Oct 2, 2020
Copy link
Member

@oxzi oxzi left a comment

LGTM

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 18, 2021

@apeyroux ping

@stale
Copy link

@stale stale bot commented Jul 27, 2021

I marked this as stale due to inactivity. → More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants