Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] freecad: 0.18.4 -> unstable-2020-09-25 #99321

Merged
merged 6 commits into from Oct 2, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 1, 2020

Motivation for this change

ZHF: #97479

Backport of #98845

Some failures on macos, because there are on master too, and if I'm going to fix them I should fix them there first and leave this as a straight backport.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
gebner added 6 commits Sep 26, 2020
(cherry picked from commit 0b53696)
(cherry picked from commit 58121fe)
@risicle risicle requested review from FRidh and jonringer as code owners Oct 1, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99321 1

11 packages built:
  • coin3d
  • freecad
  • freecadStable
  • libsForQt5.soqt
  • libsForQt512.soqt
  • libsForQt514.soqt
  • opencascade-occt730
  • python27Packages.pivy
  • python37Packages.pivy
  • python38Packages.pivy
  • soxt

@jonringer jonringer merged commit 1ee07fb into NixOS:release-20.09 Oct 2, 2020
1 of 2 checks passed
1 of 2 checks passed
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.