Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions: update-9 #99324

Merged
merged 3 commits into from Oct 2, 2020
Merged

Conversation

@eadwu
Copy link
Member

@eadwu eadwu commented Oct 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@eadwu eadwu requested a review from jonringer as a code owner Oct 1, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 1, 2020

do you mind squashing the related bumps?

git rebase -i makes this really easy

eadwu added 3 commits Sep 7, 2020
@eadwu eadwu force-pushed the eadwu:vscode-extensions/update-9 branch from fbd87db to e9b438d Oct 1, 2020
@eadwu
Copy link
Member Author

@eadwu eadwu commented Oct 2, 2020

Done.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

was able to build all 3

@jonringer jonringer merged commit 25ee6af into NixOS:master Oct 2, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.