Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeRustPlatform: Put back in it's own file. #99335

Merged

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Oct 1, 2020

Motivation for this change

We expose it on the top level, but I don't think it makes sense to pull it from a specific version of the rust tools when it is in fact version agnostic.

This reverts a tiny portion of 912dca1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Ericson2314 Ericson2314 requested review from matthewbauer and Mic92 Oct 1, 2020
@Ericson2314 Ericson2314 requested review from andir and LnL7 as code owners Oct 1, 2020
@ofborg ofborg bot added the 6.topic: rust label Oct 2, 2020
Kloenk
Kloenk approved these changes Oct 8, 2020
Copy link
Member

@Kloenk Kloenk left a comment

LGTM
edit: did not see that ofborg does not eval, that probably should be fixed.

We expose it on the top level, but I don't think it makes sense to pull
it from a specific version of the rust tools when it is in fact version
agnostic.

This reverts a tiny portion of 912dca1.
@Ericson2314 Ericson2314 force-pushed the make-rust-platform-separate branch from 65b487c to 54b4b47 Oct 14, 2020
@Ericson2314 Ericson2314 merged commit f3db41d into NixOS:master Oct 14, 2020
16 checks passed
@Ericson2314 Ericson2314 deleted the make-rust-platform-separate branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants