Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] precice: fix build, 2.0.2 -> 2.1.0, enable for darwin #99338

Merged
merged 3 commits into from Oct 2, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 1, 2020

Motivation for this change

ZHF: #97479

Backport of #99118

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
risicle added 3 commits Sep 29, 2020
cmake gets confused with python 3.8's version number, switch back to 3.7
for now until upstream's resolved that

(cherry picked from commit 5afdaa2)
(cherry picked from commit c943e6b)
(cherry picked from commit 509208e)
@risicle risicle changed the title precice: fix build, 2.0.2 -> 2.1.0, enable for darwin [20.09] precice: fix build, 2.0.2 -> 2.1.0, enable for darwin Oct 1, 2020
@ofborg ofborg bot requested a review from Scriptkiddi Oct 2, 2020
@r-burns
r-burns approved these changes Oct 2, 2020
Copy link
Contributor

@r-burns r-burns left a comment

WFM macOS 10.14

@risicle risicle merged commit a5bf6a2 into NixOS:release-20.09 Oct 2, 2020
18 checks passed
18 checks passed
action
Details
precice, precice.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6f3203b"; rev="6f3203bde2b0c44182c3c5e3db2da2080bbc02b5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6f3203b"; rev="6f3203bde2b0c44182c3c5e3db2da2080bbc02b5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6f3203b"; rev="6f3203bde2b0c44182c3c5e3db2da2080bbc02b5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6f3203b"; rev="6f3203bde2b0c44182c3c5e3db2da2080bbc02b5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6f3203b"; rev="6f3203bde2b0c44182c3c5e3db2da2080bbc02b5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6f3203b"; rev="6f3203bde2b0c44182c3c5e3db2da2080bbc02b5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6f3203b"; rev="6f3203bde2b0c44182c3c5e3db2da2080bbc02b5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
precice, precice.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.