Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/plasma5: Enable browser integration #99339

Merged
merged 1 commit into from Oct 2, 2020

Conversation

@andir
Copy link
Member

@andir andir commented Oct 1, 2020

Motivation for this change

I received this diff via email. Posting it here for review.

This option is not documented anywhere and while it may be set
in configuration.nix to enable integration, having it on by
default when using both plasma and firefox is a great convenience;
just like all other desktop environments do it already.
@andir andir requested a review from ttuegel Oct 1, 2020
Copy link
Member

@worldofpeace worldofpeace left a comment

We do similar in gnome with chrome-gnome-shell. I'm assuming the plasma module isn't broken up like gnome is so all the setup should be done already.

@schmittlauch
Copy link
Contributor

@schmittlauch schmittlauch commented Oct 2, 2020

I'm running this successfully for several months in 20.03 (manually enabled it via the config.nix).
Works like a charme, great idea to enable this by default.

@peterhoeg peterhoeg merged commit fb13347 into NixOS:master Oct 2, 2020
16 checks passed
16 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5714b5d"; rev="5714b5d37106b491e1218c42fbad985eec174944"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5714b5d"; rev="5714b5d37106b491e1218c42fbad985eec174944"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5714b5d"; rev="5714b5d37106b491e1218c42fbad985eec174944"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5714b5d"; rev="5714b5d37106b491e1218c42fbad985eec174944"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5714b5d"; rev="5714b5d37106b491e1218c42fbad985eec174944"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5714b5d"; rev="5714b5d37106b491e1218c42fbad985eec174944"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5714b5d"; rev="5714b5d37106b491e1218c42fbad985eec174944"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.