Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nftables: Warn about correct firewall setting #99340

Merged
merged 1 commit into from Oct 2, 2020

Conversation

@andir
Copy link
Member

@andir andir commented Oct 1, 2020

Motivation for this change

The firewall settings must have been moved at some point and the assertion message in the nftables module must have been missed.

services.networking.firewall might have existed during import of this
module in 2016, but it is unknown as of today.

Point to the proper boolean knob to avoid confusion.
@andir andir merged commit 66c3ba6 into NixOS:master Oct 2, 2020
18 of 19 checks passed
18 of 19 checks passed
tests tests
Details
action
Details
nftables, nftables.passthru.tests on x86_64-darwin
Details
nftables, nftables.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e438d4a"; rev="e438d4a04f505adf63a453df7173278db6ee817c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e438d4a"; rev="e438d4a04f505adf63a453df7173278db6ee817c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e438d4a"; rev="e438d4a04f505adf63a453df7173278db6ee817c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e438d4a"; rev="e438d4a04f505adf63a453df7173278db6ee817c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e438d4a"; rev="e438d4a04f505adf63a453df7173278db6ee817c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e438d4a"; rev="e438d4a04f505adf63a453df7173278db6ee817c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e438d4a"; rev="e438d4a04f505adf63a453df7173278db6ee817c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nftables, nftables.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.