Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: Enable ANGLE #99343

Closed
wants to merge 1 commit into from
Closed

chromium: Enable ANGLE #99343

wants to merge 1 commit into from

Conversation

@TredwellGit
Copy link
Contributor

@TredwellGit TredwellGit commented Oct 1, 2020

Motivation for this change

Notably fixes the bug that caused dragging text or images to crash the hardware renderer. Please backport.

Things done

Only tested and built chromium not chromiumBeta and chromiumDev.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
@TredwellGit
Copy link
Contributor Author

@TredwellGit TredwellGit commented Oct 1, 2020

Unrelated to this pull request, but in the next few days I will submit another with many more Chromium fixes.

@ofborg ofborg bot requested review from bendlas, primeos and thefloweringash Oct 2, 2020
@primeos primeos self-assigned this Oct 2, 2020
@primeos primeos changed the title chromium: fix ANGLE chromium: Enable ANGLE Oct 2, 2020
Copy link
Member

@primeos primeos left a comment

Thanks, that was on my TODO list for M86 and this makes things way easier :)
Did you happen to test this with VA-API? IIRC this should cause problems on M85. But we can merge it in ~4 days anyway when M86 is released.

Looking forward to your other changes (Chromium needs more love and maintainers).

@TredwellGit TredwellGit force-pushed the TredwellGit:chromium branch from 68ab134 to 6ce640d Oct 3, 2020
@TredwellGit
Copy link
Contributor Author

@TredwellGit TredwellGit commented Oct 3, 2020

Did you happen to test this with VA-API?

No, I never managed to get VA-API working in the first place.

Could you note in a comment which shared objects this installs (would make the review easier)?

It is probably not necessary to copy all the files it that currently does, but I will fix that in a later pull request.

Looking forward to your other changes (Chromium needs more love and maintainers).

I am going to wait until this is merged.

@ofborg ofborg bot requested a review from primeos Oct 3, 2020
@TredwellGit
Copy link
Contributor Author

@TredwellGit TredwellGit commented Oct 7, 2020

@TredwellGit TredwellGit closed this Oct 7, 2020
@TredwellGit TredwellGit deleted the TredwellGit:chromium branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.