Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartdns: 30 -> 33 #99347

Merged
merged 1 commit into from Oct 2, 2020
Merged

smartdns: 30 -> 33 #99347

merged 1 commit into from Oct 2, 2020

Conversation

@LEXUGE
Copy link
Contributor

@LEXUGE LEXUGE commented Oct 2, 2020

Bump release from 30 to 33 for smartdns.

Motivation for this change
Things done

Simply bump the version number

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Bump release from 30 to 33 for smartdns.
Copy link
Member

@danieldk danieldk left a comment

LGTM, binary works.

Result of nixpkgs-review pr 99347 1

1 package built:
  • smartdns
@danieldk danieldk merged commit 8a405a1 into NixOS:master Oct 2, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
smartdns, smartdns.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f0a5dd2"; rev="f0a5dd2a208851553a0765db1e3299875e495c56"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f0a5dd2"; rev="f0a5dd2a208851553a0765db1e3299875e495c56"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f0a5dd2"; rev="f0a5dd2a208851553a0765db1e3299875e495c56"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f0a5dd2"; rev="f0a5dd2a208851553a0765db1e3299875e495c56"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f0a5dd2"; rev="f0a5dd2a208851553a0765db1e3299875e495c56"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f0a5dd2"; rev="f0a5dd2a208851553a0765db1e3299875e495c56"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f0a5dd2"; rev="f0a5dd2a208851553a0765db1e3299875e495c56"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
smartdns, smartdns.passthru.tests on x86_64-linux Success
Details
@LEXUGE
Copy link
Contributor Author

@LEXUGE LEXUGE commented Oct 2, 2020

Thanks. Actually I am the maintainer of this package. I wonder if there is an option for me to have the write access to smartdns-related files.

@LEXUGE LEXUGE deleted the LEXUGE:patch-2 branch Oct 2, 2020
@danieldk
Copy link
Member

@danieldk danieldk commented Oct 2, 2020

Thanks. Actually I am the maintainer of this package. I wonder if there is an option for me to have the write access to smartdns-related files.

As far as I know, it is currently only possible to give commit access to all of nixpkgs or nothing. There was an RFC to give maintainers the possibility to merge PRs through a bot, but the submitter had to close it due to a lack of time. Hopefully someone will pick it up again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.