Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl-example: init at 1.0.1 #99348

Merged
merged 1 commit into from Feb 18, 2021

Conversation

@bryanasdev000
Copy link
Member

@bryanasdev000 bryanasdev000 commented Oct 2, 2020

Motivation for this change

Add kubectl-example, a simple CLI for retrieving resource example YAMLs of Kubernetes, in standalone mode (without krew, kubectl plugin manager).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bryanasdev000 bryanasdev000 force-pushed the package-kubectl-example branch from a710f91 to 8e43a66 Feb 15, 2021
@bryanasdev000
Copy link
Member Author

@bryanasdev000 bryanasdev000 commented Feb 15, 2021

Hi @SuperSandro2000 sorry for the delay in fixing this. Thanks for your time.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Feb 17, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99348 run on x86_64-linux 1

1 package built:
  • kubectl-example

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

kubectl-example:

Unused argument: stdenv.
Near pkgs/applications/networking/cluster/kubectl-example/default.nix:1:3:

  |
1 | { stdenv, lib, buildGoModule, fetchFromGitHub }:
  |   ^

@bryanasdev000 bryanasdev000 force-pushed the package-kubectl-example branch from 8e43a66 to c6e441b Feb 17, 2021
Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
@bryanasdev000 bryanasdev000 force-pushed the package-kubectl-example branch from c6e441b to 1c1aa06 Feb 18, 2021
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Feb 18, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99348 run on x86_64-darwin 1

1 package built:
  • kubectl-example

@SuperSandro2000 SuperSandro2000 merged commit 7ec23be into NixOS:master Feb 18, 2021
20 checks passed
@bryanasdev000 bryanasdev000 deleted the package-kubectl-example branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants