Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandboxfs: init at 0.2.0 #99353

Merged
merged 2 commits into from Oct 3, 2020
Merged

sandboxfs: init at 0.2.0 #99353

merged 2 commits into from Oct 3, 2020

Conversation

@jeremyschlatter
Copy link
Contributor

@jeremyschlatter jeremyschlatter commented Oct 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS doesn't build on macOS b/c of fuse dependency
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@danieldk danieldk left a comment

Thanks, looks good! Two small requested changes.

sha256 = "Ia6rq6FN4abnvLXjlQh4Q+8ra5JThKnC86UXC7s9//U=";
};

cargoSha256 = "sha256-k303TjWG+n+/ZMmko84KJtYb7swuQ1ZJOc4Vq6aOhX0=";

This comment has been minimized.

@danieldk

danieldk Oct 2, 2020
Member

I always forget if we already permit SRI hashes, but from a quick grep it seems that we have a lot of them already.

This comment has been minimized.

@jeremyschlatter

jeremyschlatter Oct 2, 2020
Author Contributor

I computed these hashes by setting these fields to the empty string and then copy-pasting the hash in the error message from nix-build. This is the format that nix-build used to print them. I'd be happy to switch to a different format if that's preferable.

pkgs/tools/filesystems/sandboxfs/default.nix Outdated Show resolved Hide resolved
@jeremyschlatter
Copy link
Contributor Author

@jeremyschlatter jeremyschlatter commented Oct 2, 2020

Thanks for the review! I made those two small changes.

@jeremyschlatter jeremyschlatter requested a review from danieldk Oct 2, 2020
Copy link
Member

@danieldk danieldk left a comment

LGTM

Result of nixpkgs-review pr 99353 1

1 package built:
  • sandboxfs
@danieldk danieldk merged commit 87278e9 into NixOS:master Oct 3, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
sandboxfs, sandboxfs.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0efdbb1"; rev="0efdbb1bc9c27b972b06ee3e06af0657376c43ea"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0efdbb1"; rev="0efdbb1bc9c27b972b06ee3e06af0657376c43ea"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0efdbb1"; rev="0efdbb1bc9c27b972b06ee3e06af0657376c43ea"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0efdbb1"; rev="0efdbb1bc9c27b972b06ee3e06af0657376c43ea"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0efdbb1"; rev="0efdbb1bc9c27b972b06ee3e06af0657376c43ea"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0efdbb1"; rev="0efdbb1bc9c27b972b06ee3e06af0657376c43ea"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0efdbb1"; rev="0efdbb1bc9c27b972b06ee3e06af0657376c43ea"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sandboxfs, sandboxfs.passthru.tests on x86_64-linux Success
Details
@jeremyschlatter jeremyschlatter deleted the jeremyschlatter:sandboxfs branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.