Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.sqlite-utils: init at 2.22 #99359

Merged
merged 2 commits into from Nov 6, 2020
Merged

Conversation

@meatcar
Copy link
Contributor

@meatcar meatcar commented Oct 2, 2020

Motivation for this change

Adding a useful tool for tweaking sqlite dbs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@meatcar meatcar force-pushed the meatcar:sqlite-utils branch from add7ea0 to b056782 Oct 3, 2020
@meatcar meatcar force-pushed the meatcar:sqlite-utils branch from b056782 to 64eba90 Oct 27, 2020
@meatcar meatcar changed the title pythonPackages.sqlite-utils: init at 2.21 pythonPackages.sqlite-utils: init at 2.22 Oct 27, 2020
@meatcar meatcar force-pushed the meatcar:sqlite-utils branch from 64eba90 to ff3dca5 Oct 27, 2020
@meatcar
Copy link
Contributor Author

@meatcar meatcar commented Oct 27, 2020

@jonringer thanks for the review, I implemented your suggestions. Also bumped up to v2.22 that was released since.

Is there anything else I should do to help this PR get merged?

Copy link
Member

@Pamplemousse Pamplemousse left a comment

LGTM 👍
Built and tested on NixOS: application starts and displays help, library imported without error in Python.

@srhb srhb merged commit e3bbada into NixOS:master Nov 6, 2020
17 checks passed
17 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff3dca5"; rev="ff3dca56ede5b2c4baedbbba627d8c6f9f91815e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff3dca5"; rev="ff3dca56ede5b2c4baedbbba627d8c6f9f91815e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff3dca5"; rev="ff3dca56ede5b2c4baedbbba627d8c6f9f91815e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff3dca5"; rev="ff3dca56ede5b2c4baedbbba627d8c6f9f91815e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff3dca5"; rev="ff3dca56ede5b2c4baedbbba627d8c6f9f91815e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff3dca5"; rev="ff3dca56ede5b2c4baedbbba627d8c6f9f91815e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff3dca5"; rev="ff3dca56ede5b2c4baedbbba627d8c6f9f91815e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.