Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsUnstable: 2.0.0-rc2 -> 2.0.0-rc3 #99361

Merged
merged 1 commit into from Oct 2, 2020
Merged

zfsUnstable: 2.0.0-rc2 -> 2.0.0-rc3 #99361

merged 1 commit into from Oct 2, 2020

Conversation

@hmenke
Copy link
Contributor

@hmenke hmenke commented Oct 2, 2020

Motivation for this change

More bugfixes: https://github.com/openzfs/zfs/releases/tag/zfs-2.0.0-rc3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@hmenke
Copy link
Contributor Author

@hmenke hmenke commented Oct 2, 2020

Result of nixpkgs-review pr 99361 1

18 packages built:
  • linuxPackages-libre.zfsUnstable
  • linuxPackages.zfsUnstable
  • linuxPackages_4_14.zfsUnstable
  • linuxPackages_4_19.zfsUnstable
  • linuxPackages_4_4.zfsUnstable
  • linuxPackages_4_9.zfsUnstable
  • linuxPackages_5_7.zfsUnstable
  • linuxPackages_5_8.zfsUnstable
  • linuxPackages_hardened.zfsUnstable
  • linuxPackages_latest-libre.zfsUnstable
  • linuxPackages_latest_hardened.zfsUnstable
  • linuxPackages_latest_xen_dom0.zfsUnstable
  • linuxPackages_latest_xen_dom0_hardened.zfsUnstable
  • linuxPackages_testing_bcachefs.zfsUnstable
  • linuxPackages_xen_dom0.zfsUnstable
  • linuxPackages_xen_dom0_hardened.zfsUnstable
  • linuxPackages_zen.zfsUnstable
  • zfsUnstable
@hmenke
Copy link
Contributor Author

@hmenke hmenke commented Oct 2, 2020

@ofborg test zfs.unstable

@hmenke
Copy link
Contributor Author

@hmenke hmenke commented Oct 2, 2020

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

tests pass

@jonringer jonringer merged commit 952b698 into NixOS:master Oct 2, 2020
21 checks passed
21 checks passed
tests tests
Details
action
Details
zfsUnstable, zfsUnstable.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a60158"; rev="7a601583dd06cd6f8358275622085df9ee116ee8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a60158"; rev="7a601583dd06cd6f8358275622085df9ee116ee8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a60158"; rev="7a601583dd06cd6f8358275622085df9ee116ee8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a60158"; rev="7a601583dd06cd6f8358275622085df9ee116ee8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a60158"; rev="7a601583dd06cd6f8358275622085df9ee116ee8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a60158"; rev="7a601583dd06cd6f8358275622085df9ee116ee8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a60158"; rev="7a601583dd06cd6f8358275622085df9ee116ee8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.zfs.unstable on aarch64-linux Success
Details
tests.zfs.unstable on x86_64-linux Success
Details
zfsUnstable, zfsUnstable.passthru.tests on x86_64-linux Success
Details
@hyperfekt
Copy link
Contributor

@hyperfekt hyperfekt commented Oct 9, 2020

Should this be backported (maybe after the 20.09 release)?

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 9, 2020

generally I would say no, but it's explicit about itself being unstable.

Seeing as most of the changes are bugfixes, I would say yes

@hyperfekt
Copy link
Contributor

@hyperfekt hyperfekt commented Oct 9, 2020

Well, rc2 is part of 20.09 as the unstable version, so that decision seems to have been made already. ^^

@clefru
Copy link
Contributor

@clefru clefru commented Oct 10, 2020

I think that zfsUnstable inside the release branch exists because we also add new kernels to the release branch, and zfs (stable) was not that good in supporting new kernels, so people saw a need to use zfs unstable. That has changed, as the stable zfs branch is pretty good in support new kernels.

But yes, -rc3 should be backported, given the precedent with 2.0.0-rc1/rc2. The real question is what we do when 2.0.0 stable gets released :). Do we go back and make zfsUnstable track the zfs master branch?

@hmenke
Copy link
Contributor Author

@hmenke hmenke commented Oct 10, 2020

@clefru In the past, zfs and zfsUnstable were just the same when there were no release candidates out. However, I expect there to be more beta updates in the future as OpenZFS wants to switch to a yearly release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.