Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] effitask: fix build #99362

Merged
merged 1 commit into from Oct 3, 2020
Merged

[20.09] effitask: fix build #99362

merged 1 commit into from Oct 3, 2020

Conversation

@mdevlamynck
Copy link
Contributor

@mdevlamynck mdevlamynck commented Oct 2, 2020

Motivation for this change

backport of #99238
ZHF: #97479
(cherry picked from commit ab0e7bf)
@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit ab0e7bf)
@davidak
davidak approved these changes Oct 2, 2020
Copy link
Member

@davidak davidak left a comment

looks good, works

thanks for backporting

@mdevlamynck
Copy link
Contributor Author

@mdevlamynck mdevlamynck commented Oct 2, 2020

Just following the process ^^

@risicle
Copy link
Contributor

@risicle risicle commented Oct 3, 2020

Yup, WFM macos 10.14

@risicle risicle merged commit 8d6f5be into NixOS:release-20.09 Oct 3, 2020
18 checks passed
18 checks passed
action
Details
effitask, effitask.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
effitask, effitask.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ed6a21f"; rev="ed6a21f97053c2453e84aee34e0e893b4970ad97"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ed6a21f"; rev="ed6a21f97053c2453e84aee34e0e893b4970ad97"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ed6a21f"; rev="ed6a21f97053c2453e84aee34e0e893b4970ad97"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ed6a21f"; rev="ed6a21f97053c2453e84aee34e0e893b4970ad97"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ed6a21f"; rev="ed6a21f97053c2453e84aee34e0e893b4970ad97"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ed6a21f"; rev="ed6a21f97053c2453e84aee34e0e893b4970ad97"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ed6a21f"; rev="ed6a21f97053c2453e84aee34e0e893b4970ad97"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.