Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddy1: remove #99371

Merged
merged 2 commits into from Oct 2, 2020
Merged

caddy1: remove #99371

merged 2 commits into from Oct 2, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 2, 2020

Motivation for this change

https://github.com/caddyserver/caddy/blob/master/.github/SECURITY.md#supported-versions

Caddy 1.x is unsupported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@doronbehar doronbehar left a comment

Diff LGTM.

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@zowoq zowoq force-pushed the zowoq:rm-caddy1 branch from 63fe973 to 8f74e9e Oct 2, 2020
@AndersonTorres AndersonTorres merged commit 26108ad into NixOS:master Oct 2, 2020
18 checks passed
18 checks passed
nixos
Details
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74e9e"; rev="8f74e9e90541fdc34a4eb228d7dbab5ff761c20d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74e9e"; rev="8f74e9e90541fdc34a4eb228d7dbab5ff761c20d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74e9e"; rev="8f74e9e90541fdc34a4eb228d7dbab5ff761c20d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74e9e"; rev="8f74e9e90541fdc34a4eb228d7dbab5ff761c20d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74e9e"; rev="8f74e9e90541fdc34a4eb228d7dbab5ff761c20d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74e9e"; rev="8f74e9e90541fdc34a4eb228d7dbab5ff761c20d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74e9e"; rev="8f74e9e90541fdc34a4eb228d7dbab5ff761c20d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:rm-caddy1 branch Oct 3, 2020
deviant added a commit to deviant/nixpkgs that referenced this pull request Oct 19, 2020
This option is no longer referenced anywhere as of NixOS#99371.
@deviant deviant mentioned this pull request Oct 19, 2020
3 of 10 tasks complete
deviant added a commit to deviant/nixpkgs that referenced this pull request Oct 30, 2020
This option is no longer referenced anywhere as of NixOS#99371.
deviant added a commit to deviant/nixpkgs that referenced this pull request Oct 30, 2020
This option is no longer referenced anywhere as of NixOS#99371.

(cherry picked from commit 580f0fa)
nlewo added a commit to nlewo/nixpkgs that referenced this pull request Oct 31, 2020
This option is no longer referenced anywhere as of NixOS#99371.

(cherry picked from commit 580f0fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.