Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knightos-mktiupgrade: init at 1.1.6 #99374

Merged
merged 1 commit into from Oct 16, 2020
Merged

Conversation

@siraben
Copy link
Contributor

@siraben siraben commented Oct 2, 2020

Motivation for this change

Add knightos-mktiupgrade

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@siraben siraben force-pushed the siraben:mktiupgrade-init branch from cbf11c8 to b982552 Oct 10, 2020
@siraben siraben force-pushed the siraben:mktiupgrade-init branch from e8ddd44 to 56c910d Oct 10, 2020
@siraben siraben changed the title knightos-mktiupgrade: init at unstable-2020-01-28 knightos-mktiupgrade: init at 1.1.6 Oct 10, 2020
@siraben
Copy link
Contributor Author

@siraben siraben commented Oct 14, 2020

Pinging @danieldk who approved KnightOS packages previously. Related open PRs: #99288 #99283 #99272.

@siraben siraben force-pushed the siraben:mktiupgrade-init branch from 1c5b378 to 2b3564d Oct 15, 2020
@danieldk danieldk force-pushed the siraben:mktiupgrade-init branch from 2b3564d to 964d192 Oct 16, 2020
@siraben
Copy link
Contributor Author

@siraben siraben commented Oct 16, 2020

Need to update description, looks like it's the one for knightos-mkrom.

@siraben siraben force-pushed the siraben:mktiupgrade-init branch from 964d192 to a617f19 Oct 16, 2020
@danieldk danieldk force-pushed the siraben:mktiupgrade-init branch from a617f19 to f8ca1be Oct 16, 2020
@danieldk
Copy link
Member

@danieldk danieldk commented Oct 16, 2020

I have pushed an update to remove arguments that are now unneeded (libxslt, docbook_xsl). Let's see if ofborg is happy now.

Copy link
Member

@danieldk danieldk left a comment

LGTM

Result of nixpkgs-review pr 99374 1

1 package built:
  • knightos-mktiupgrade
@danieldk danieldk merged commit e7add4a into NixOS:master Oct 16, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
knightos-mktiupgrade, knightos-mktiupgrade.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ca1be"; rev="f8ca1bebdf8d6f6df2d32ce18e210489398a8994"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ca1be"; rev="f8ca1bebdf8d6f6df2d32ce18e210489398a8994"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ca1be"; rev="f8ca1bebdf8d6f6df2d32ce18e210489398a8994"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ca1be"; rev="f8ca1bebdf8d6f6df2d32ce18e210489398a8994"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ca1be"; rev="f8ca1bebdf8d6f6df2d32ce18e210489398a8994"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ca1be"; rev="f8ca1bebdf8d6f6df2d32ce18e210489398a8994"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ca1be"; rev="f8ca1bebdf8d6f6df2d32ce18e210489398a8994"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
knightos-mktiupgrade, knightos-mktiupgrade.passthru.tests on x86_64-linux Success
Details
@siraben siraben deleted the siraben:mktiupgrade-init branch Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.