Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php74: 7.4.8 -> 7.4.11 #99376

Merged
merged 1 commit into from Oct 3, 2020
Merged

php74: 7.4.8 -> 7.4.11 #99376

merged 1 commit into from Oct 3, 2020

Conversation

@etu
Copy link
Contributor

@etu etu commented Oct 2, 2020

Motivation for this change

https://www.php.net/ChangeLog-7.php#7.4.9
https://www.php.net/ChangeLog-7.php#7.4.10
https://www.php.net/ChangeLog-7.php#7.4.11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@etu etu requested a review from NixOS/php Oct 2, 2020
@etu
Copy link
Contributor Author

@etu etu commented Oct 2, 2020

@ofborg build php74 php74.tests

Copy link
Contributor

@aanderse aanderse left a comment

LGTM 👍

Anyone have a darwin machine they could test the build of this on?

@Ma27
Ma27 approved these changes Oct 3, 2020
Copy link
Member

@Ma27 Ma27 left a comment

LGTM 👍

Currently building it on an older Mac machine we have in the office as it's unused on weekends %)

@Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 3, 2020

On x86_64-darwin I get the output-path /nix/store/6yx6i0lzaka1x505djaji8nnkdg32jzg-php-with-extensions-7.4.11 for php74. I did some basic usage tests, so it should be good to go. Currently testing php73 on darwin, would backport both after that.

@Ma27 Ma27 merged commit 73cf983 into NixOS:master Oct 3, 2020
20 of 23 checks passed
20 of 23 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
php74, php74.passthru.tests on x86_64-darwin
Details
php74, php74.tests on x86_64-darwin
Details
php74, php74.passthru.tests on aarch64-linux No attempt
Details
php74, php74.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a792db6"; rev="a792db658f6cfbd2748d8e5ab90f873140a14f2f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a792db6"; rev="a792db658f6cfbd2748d8e5ab90f873140a14f2f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a792db6"; rev="a792db658f6cfbd2748d8e5ab90f873140a14f2f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a792db6"; rev="a792db658f6cfbd2748d8e5ab90f873140a14f2f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a792db6"; rev="a792db658f6cfbd2748d8e5ab90f873140a14f2f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a792db6"; rev="a792db658f6cfbd2748d8e5ab90f873140a14f2f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a792db6"; rev="a792db658f6cfbd2748d8e5ab90f873140a14f2f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
php74, php74.passthru.tests on x86_64-linux Success
Details
php74, php74.tests on x86_64-linux Success
Details
@Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 3, 2020

20.09: 07c6f1f
20.03: 960c3fc

@etu etu deleted the etu:php74-update branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.