Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php73: 7.3.20 -> 7.3.23 #99377

Merged
merged 1 commit into from Oct 3, 2020
Merged

php73: 7.3.20 -> 7.3.23 #99377

merged 1 commit into from Oct 3, 2020

Conversation

@etu
Copy link
Contributor

@etu etu commented Oct 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@etu etu requested a review from Oct 2, 2020
@etu etu changed the title php73: 7.3.20 => 7.3.23 php73: 7.3.20 -> 7.3.23 Oct 2, 2020
@etu etu force-pushed the php73-update branch from f2aca18 to e04af50 Oct 2, 2020
@etu
Copy link
Contributor Author

@etu etu commented Oct 2, 2020

@ofborg build php73

Copy link
Member

@aanderse aanderse left a comment

LGTM 👍

Ma27
Ma27 approved these changes Oct 3, 2020
@Ma27 Ma27 merged commit 385eeb4 into NixOS:master Oct 3, 2020
20 of 23 checks passed
@Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 3, 2020

Thanks!
20.09: beea522
20.03: 8c9449e

@etu etu deleted the php73-update branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants