Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAFS 1.8 fixups #99379

Merged
merged 3 commits into from Nov 17, 2020
Merged

OpenAFS 1.8 fixups #99379

merged 3 commits into from Nov 17, 2020

Conversation

@spacefrogg
Copy link
Contributor

@spacefrogg spacefrogg commented Oct 2, 2020

Motivation for this change

Volume salvaging was partly broken. Parallel building is also broken.

Things done

Some fixes and improvements:

  • FIX :: disable parallel building, as it is broken (in rare cases)
  • FIX :: merge the server output with out, as it was breaking volume salvaging, due to hard-coded cross dependencies that got broken during fixup phase
  • IMPROVEMENT :: add option to produce developer documentation
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@roberth
Copy link
Contributor

@roberth roberth commented Nov 6, 2020

Please update the commit author with git config, git rebase -i, its e command and git commit --reset-author, or update your github e-mail settings to include a match with the existing commits at http://github.com/settings/emails
Exceptions might be possible, but github behaves better when it matches.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Nov 15, 2020

Could you incorporate #103860 ?

Michael Raitza added 3 commits Oct 2, 2020
Parallel building is broken, leading to failing builds in very rare
cases. (volint.h not yet built while alredy needed when compiling volser.)
User and server binaries cannot be shipped separately. The bos tool uses a
hard-coded path to the volume salvage command (which resides with the server
binaries). Splitting them into separate outputs invalidates the reference in the
bos tool (due to remove-references-to). This rendered the volume salvager
inoperable (which is obviously a bad thing).
@Mic92 Mic92 force-pushed the spacefrogg:openafs-fixups branch from 1141ba2 to 54a69eb Nov 17, 2020
@spacefrogg
Copy link
Contributor Author

@spacefrogg spacefrogg commented Nov 17, 2020

Sure.

@Mic92 Mic92 merged commit dd1908f into NixOS:master Nov 17, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Details
action action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@Mic92 Mic92 mentioned this pull request Nov 17, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.