Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.adguardhome: init at 0.4.2 #99391

Merged
merged 1 commit into from Oct 2, 2020
Merged

Conversation

@JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Oct 2, 2020

Motivation for this change

Support adguard in home assistant

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@JamieMagee JamieMagee requested review from FRidh and jonringer as code owners Oct 2, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99391 1

2 packages built:
  • python37Packages.adguardhome
  • python38Packages.adguardhome

@jonringer jonringer merged commit bc99830 into NixOS:master Oct 2, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 2, 2020

I think you need to run a script for home-assistant to attempt to bring in the new dependency @mweinelt

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 2, 2020

Yeah, the one at ./pkgs/servers/home-assistant/parse-requirements.py, it has a proper she-bang, so one can just execute it.

I will do a rebase on #99217 though and pick up this change. Thanks for the poke!

@JamieMagee JamieMagee deleted the JamieMagee:adguardhome branch Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.