Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomplate: init at 3.8.0 #99402

Merged
merged 1 commit into from Oct 4, 2020
Merged

gomplate: init at 3.8.0 #99402

merged 1 commit into from Oct 4, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 2, 2020

Motivation for this change

gomplate is a template renderer which supports a growing list of datasources

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Oct 2, 2020

I tried to make some suggestions using the built in code suggestions feature but it was pretty messy so I put them on another branch for you to look through:
https://github.com/06kellyjac/nixpkgs/commits/ris-gomplate-init

  • gomplate: move vendorSha256 next to src
    I prefer the vendorSha256 next to src and I always see them together.

  • gomplate: clean up meta
    Can just do the with stdenv.lib on meta once to make things cleaner.

  • gomplate: add version info
    The rev was only useful in src so usually I'd move it in there, but it's actually useful for feeding gomplate it's version.
    Sets github.com/hairyhenderson/gomplate/v3/version.Version=v3.8.0 using existing values

image

Feel free to cherrypick these commits or copy/paste 🙂

@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 2, 2020

Thanks - I'm very much foreign to the golang corners of nix... will sneak some of those fixes. I turn off "allow modifications" because it really confuses me when people do that.

@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 2, 2020

Oh dear I should have checked for existing PRs: #85157

@jlesquembre if you don't mind I might add you as a co-maintainer of this as you seemed to have interest before?

@risicle risicle force-pushed the risicle:ris-gomplate-init branch from 8aacf9c to 694c843 Oct 2, 2020
@risicle risicle force-pushed the risicle:ris-gomplate-init branch from 694c843 to d451ecb Oct 2, 2020
@ofborg ofborg bot requested a review from jlesquembre Oct 3, 2020
Copy link
Contributor

@06kellyjac 06kellyjac left a comment

LGTM 👍
Probably best to get confirmation @jlesquembre is still ok being a maintainer before merging.

@jlesquembre
Copy link
Contributor

@jlesquembre jlesquembre commented Oct 3, 2020

Writing from my phone, I didn't have time to check it, but ok to leave me as maintainer. Happy to see gomplate in nixpkgs

@risicle risicle merged commit 4de226e into NixOS:master Oct 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
gomplate, gomplate.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
gomplate, gomplate.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d451ecb"; rev="d451ecbc9cdefa7a1f62c726dfc78107c24e4a34"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d451ecb"; rev="d451ecbc9cdefa7a1f62c726dfc78107c24e4a34"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d451ecb"; rev="d451ecbc9cdefa7a1f62c726dfc78107c24e4a34"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d451ecb"; rev="d451ecbc9cdefa7a1f62c726dfc78107c24e4a34"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d451ecb"; rev="d451ecbc9cdefa7a1f62c726dfc78107c24e4a34"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d451ecb"; rev="d451ecbc9cdefa7a1f62c726dfc78107c24e4a34"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d451ecb"; rev="d451ecbc9cdefa7a1f62c726dfc78107c24e4a34"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@risicle risicle mentioned this pull request Oct 4, 2020
3 of 10 tasks complete
@06kellyjac 06kellyjac mentioned this pull request Oct 4, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.