Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wally-cli: bump to 2.0.0 #99405

Merged
merged 1 commit into from Oct 3, 2020
Merged

wally-cli: bump to 2.0.0 #99405

merged 1 commit into from Oct 3, 2020

Conversation

@steveeJ
Copy link
Contributor

@steveeJ steveeJ commented Oct 2, 2020

Motivation for this change

New version supports new hardware.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
etu
etu approved these changes Oct 3, 2020
Copy link
Contributor

@etu etu left a comment

Overall I approve these changes. From looking at hydra it didn't seem to build on darwin before either. So it wouldn't regress by starting to not build on darwin.

One might want to add platforms = platforms.linux; to the meta to make darwin an unsupported platform instead of just having failures.

pkgs/development/tools/wally-cli/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/wally-cli/default.nix Outdated Show resolved Hide resolved
@steveeJ steveeJ force-pushed the pr/bump-wally-2.0 branch from eadcc28 to aba8b07 Oct 3, 2020
@steveeJ
Copy link
Contributor Author

@steveeJ steveeJ commented Oct 3, 2020

Thanks @etu

I incorporated your suggestions. For some reasons squashing your commits into my first one swallowed your co-authorship though 🤔

@etu etu merged commit bf9dc8a into NixOS:master Oct 3, 2020
19 checks passed
@etu
Copy link
Contributor

@etu etu commented Oct 3, 2020

@steveeJ That's fine, thanks 🙂

@steveeJ steveeJ deleted the pr/bump-wally-2.0 branch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants