Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivy: init at 0.11.0 #99407

Merged
merged 1 commit into from Oct 13, 2020
Merged

trivy: init at 0.11.0 #99407

merged 1 commit into from Oct 13, 2020

Conversation

@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Oct 2, 2020

Motivation for this change

Add the trivy vulnerability scanner to nixpkgs

I categorized it in tools/admin because that's where the clair vulnerability scanner is already.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions (aarch64 archlinux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/316

@06kellyjac 06kellyjac force-pushed the 06kellyjac:init_trivy branch 2 times, most recently from c527634 to b52b077 Oct 13, 2020
@06kellyjac 06kellyjac requested a review from AndersonTorres Oct 13, 2020
@06kellyjac 06kellyjac force-pushed the 06kellyjac:init_trivy branch from b52b077 to b666031 Oct 13, 2020
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Just cosmetic changes. We need beautiful code too :)

pkgs/tools/admin/trivy/default.nix Outdated Show resolved Hide resolved
@06kellyjac 06kellyjac force-pushed the 06kellyjac:init_trivy branch from b666031 to aa7a16a Oct 13, 2020
@AndersonTorres AndersonTorres self-requested a review Oct 13, 2020
Copy link
Member

@AndersonTorres AndersonTorres left a comment

LGTM, LGTBorg

@AndersonTorres AndersonTorres merged commit f67893d into NixOS:master Oct 13, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa7a16a"; rev="aa7a16a72f16926ab0f6e284c416d73034d5c747"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa7a16a"; rev="aa7a16a72f16926ab0f6e284c416d73034d5c747"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa7a16a"; rev="aa7a16a72f16926ab0f6e284c416d73034d5c747"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa7a16a"; rev="aa7a16a72f16926ab0f6e284c416d73034d5c747"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa7a16a"; rev="aa7a16a72f16926ab0f6e284c416d73034d5c747"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa7a16a"; rev="aa7a16a72f16926ab0f6e284c416d73034d5c747"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa7a16a"; rev="aa7a16a72f16926ab0f6e284c416d73034d5c747"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
trivy, trivy.passthru.tests on aarch64-linux Success
Details
trivy, trivy.passthru.tests on x86_64-linux Success
Details
@06kellyjac 06kellyjac deleted the 06kellyjac:init_trivy branch Oct 13, 2020
@06kellyjac
Copy link
Contributor Author

@06kellyjac 06kellyjac commented Oct 13, 2020

Thanks for the reviews @AndersonTorres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.