Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/shiori: harden service with systemd #99408

Merged
merged 1 commit into from Oct 28, 2020

Conversation

@minijackson
Copy link
Contributor

@minijackson minijackson commented Oct 2, 2020

Motivation for this change

It's best when it's hardened

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@minijackson minijackson force-pushed the minijackson:shiori-harden-service branch from f6a9271 to 9b01416 Oct 27, 2020
@aanderse
Copy link
Contributor

@aanderse aanderse commented Oct 27, 2020

@minijackson I wonder if you would be interested in submitting a PR upstream to add a systemd unit so others could benefit.

@bjornfor I'll leave to you to merge this because I'm not familiar with this software.

@bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Oct 28, 2020

@bjornfor I'll leave to you to merge this because I'm not familiar with this software.

I'm not either :-)

@bjornfor bjornfor merged commit 3fce272 into NixOS:master Oct 28, 2020
16 checks passed
16 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9b01416"; rev="9b0141608cbdeddc666c3833df94d78d6cbda51c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9b01416"; rev="9b0141608cbdeddc666c3833df94d78d6cbda51c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9b01416"; rev="9b0141608cbdeddc666c3833df94d78d6cbda51c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9b01416"; rev="9b0141608cbdeddc666c3833df94d78d6cbda51c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9b01416"; rev="9b0141608cbdeddc666c3833df94d78d6cbda51c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9b01416"; rev="9b0141608cbdeddc666c3833df94d78d6cbda51c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9b01416"; rev="9b0141608cbdeddc666c3833df94d78d6cbda51c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@minijackson minijackson deleted the minijackson:shiori-harden-service branch Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.