Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot: 3.2.2 -> 3.2.3 #99411

Merged
merged 1 commit into from Oct 3, 2020
Merged

godot: 3.2.2 -> 3.2.3 #99411

merged 1 commit into from Oct 3, 2020

Conversation

@fatho
Copy link
Contributor

@fatho fatho commented Oct 2, 2020

Motivation for this change

There's a newer upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    It says No diff detected, stopping review..., probably doing something wrong here. nixpkgs-review rev HEAD did the trick, but everything was already built.

  • Tested execution of all binary files (usually in ./result/bin/)
    Ran godot, godot-server and godot-headless

  • Determined the impact on package closure size (by running nix path-info -S before and after)

    Before: 126467128
    After: 126697864

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

@marsam marsam merged commit bbc13f8 into NixOS:master Oct 3, 2020
19 checks passed
@fatho fatho deleted the godot-3.2.3 branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants