Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stenc: 1.0.7 -> 1.0.8 #99418

Merged
merged 1 commit into from Jan 23, 2021
Merged

stenc: 1.0.7 -> 1.0.8 #99418

merged 1 commit into from Jan 23, 2021

Conversation

@woffs
Copy link
Contributor

@woffs woffs commented Oct 2, 2020

Motivation for this change

update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 99418 run on x86_64-linux 1

1 package built:
  • stenc

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Cab you solve the merge conflict?

@woffs
Copy link
Contributor Author

@woffs woffs commented Nov 26, 2020

Cab you solve the merge conflict?

done.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 18, 2021

@woffs please solve the merge conflict.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 21, 2021

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99418 run on x86_64-linux 1

1 package built:
  • stenc

sha256 = "0dsmvr1xpwkcd9yawv4c4vna67yag7jb8jcgn2amywz7nkpzmyxd";
};

nativeBuildInputs = [ autoconf automake autoreconfHook ];
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 21, 2021

Suggested change
nativeBuildInputs = [ autoconf automake autoreconfHook ];
nativeBuildInputs = [ autoreconfHook ];

autoreconfHook should include those.

, autoconf
, automake
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 21, 2021

Suggested change
, autoconf
, automake

@symphorien symphorien merged commit c3bb176 into NixOS:master Jan 23, 2021
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants