Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.bip_utils: 1.4.0 -> 1.5.0 #99419

merged 1 commit into from Oct 2, 2020


Copy link

@prusnak prusnak commented Oct 2, 2020

Motivation for this change

Version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@prusnak prusnak requested review from FRidh and jonringer as code owners Oct 2, 2020
Copy link

@mweinelt mweinelt commented Oct 2, 2020

The change itself LGTM. Can you move the src to fetchFromGitHub and try to enable tests?

Result of nixpkgs-review pr 99419 1

2 packages built:
  • python37Packages.bip_utils
  • python38Packages.bip_utils
fetch sources from GitHub instead of PyPI to enable tests
@prusnak prusnak force-pushed the prusnak:bip_utils branch from fd52bd3 to f1057db Oct 2, 2020
Copy link
Member Author

@prusnak prusnak commented Oct 2, 2020

@mweinelt tests enabled in f1057db

@mweinelt mweinelt merged commit 1a5bbec into NixOS:master Oct 2, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
@prusnak prusnak deleted the prusnak:bip_utils branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.