Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rgxg: init at 0.1.2 #99422

Merged
merged 2 commits into from Oct 8, 2020
Merged

Rgxg: init at 0.1.2 #99422

merged 2 commits into from Oct 8, 2020

Conversation

@hloeffler
Copy link
Contributor

@hloeffler hloeffler commented Oct 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@hloeffler hloeffler mentioned this pull request Oct 2, 2020
2 of 10 tasks complete
@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 2, 2020

@hloeffler can you rebase this, please?

@AndersonTorres AndersonTorres changed the title Rgxg init 0.1.2 Rgxg: init at 0.1.2 Oct 2, 2020
@hloeffler hloeffler force-pushed the hloeffler:rgxg-init-0.1.2 branch from 47dd666 to 4862ebe Oct 3, 2020
@hloeffler
Copy link
Contributor Author

@hloeffler hloeffler commented Oct 3, 2020

@AndersonTorres
Yes, sorry for the mess.

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 4, 2020

@hloeffler ping

@hloeffler hloeffler force-pushed the hloeffler:rgxg-init-0.1.2 branch from 4862ebe to 9fe675e Oct 4, 2020
@hloeffler
Copy link
Contributor Author

@hloeffler hloeffler commented Oct 4, 2020

@AndersonTorres rebased

Copy link
Member

@AndersonTorres AndersonTorres left a comment

@hloeffler change the code as shown below the changes below

pkgs/tools/text/rgxg/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/rgxg/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/rgxg/default.nix Outdated Show resolved Hide resolved
@hloeffler
Copy link
Contributor Author

@hloeffler hloeffler commented Oct 5, 2020

I think i need help,
if i build from repo, i do need the .git dir for ./version.sh

and now i'm down the rabbithole til:
#24169

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 6, 2020

leaveDotGit=true; inside fetchFromGitHub.

Also, remember to interactively rebase it to only two commits.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 6, 2020

leaveDotGit=true; inside fetchFromGitHub.

It's considered back practice from the point of reproducibility: #8567 .

@hloeffler hloeffler force-pushed the hloeffler:rgxg-init-0.1.2 branch 3 times, most recently from 2637887 to 80f8797 Oct 6, 2020
@hloeffler hloeffler requested a review from AndersonTorres Oct 6, 2020
Copy link
Contributor Author

@hloeffler hloeffler left a comment

done and rebased ( also added a comment)

@hloeffler hloeffler force-pushed the hloeffler:rgxg-init-0.1.2 branch 2 times, most recently from 09d9ff8 to eb6c39d Oct 7, 2020
Co-authored-by: Doron Behar <doron.behar@gmail.com>
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
@hloeffler hloeffler force-pushed the hloeffler:rgxg-init-0.1.2 branch from eb6c39d to 90e603f Oct 7, 2020
@hloeffler hloeffler requested review from AndersonTorres and doronbehar Oct 7, 2020
@hloeffler
Copy link
Contributor Author

@hloeffler hloeffler commented Oct 7, 2020

I'm done :-)
Was easy.

(Thank you!)

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 8, 2020

Now it is OK! Many thanks, guy! (or gal, I don't know :-) )

@AndersonTorres AndersonTorres merged commit cac0cfa into NixOS:master Oct 8, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90e603f"; rev="90e603fcecf47fb41b9e32f2668540294d4801d7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90e603f"; rev="90e603fcecf47fb41b9e32f2668540294d4801d7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90e603f"; rev="90e603fcecf47fb41b9e32f2668540294d4801d7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90e603f"; rev="90e603fcecf47fb41b9e32f2668540294d4801d7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90e603f"; rev="90e603fcecf47fb41b9e32f2668540294d4801d7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90e603f"; rev="90e603fcecf47fb41b9e32f2668540294d4801d7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90e603f"; rev="90e603fcecf47fb41b9e32f2668540294d4801d7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rgxg, rgxg.passthru.tests on aarch64-linux Success
Details
rgxg, rgxg.passthru.tests on x86_64-linux Success
Details
@hloeffler hloeffler deleted the hloeffler:rgxg-init-0.1.2 branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.