Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kapowbang: rename from kapow #99427

Merged
merged 1 commit into from Oct 3, 2020
Merged

kapowbang: rename from kapow #99427

merged 1 commit into from Oct 3, 2020

Conversation

@orivej
Copy link
Contributor

@orivej orivej commented Oct 2, 2020

Motivation for this change

kapow is an established name of an older project, being packaged in #78407.
Repology and ArchLinux call the Go project kapowbang because its name is "Kapow!":
https://github.com/BBVA/kapow
https://repology.org/projects/?search=kapow
https://aur.archlinux.org/packages/?K=kapow
Kapow! was packaged as kapow in #88458.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc maintainer @nilp0inter

kapow is an established name of an older project, being packaged in #78407.
Repology and ArchLinux call the Go project kapowbang because its name is "Kapow!":
https://github.com/BBVA/kapow
https://repology.org/projects/?search=kapow
https://aur.archlinux.org/packages/?K=kapow
@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 2, 2020

There is no package associated with it?

@orivej
Copy link
Contributor Author

@orivej orivej commented Oct 2, 2020

This PR will allow #78407 to add kapow.

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 3, 2020

Ok then.

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 3, 2020

Why OfBorg is slow? 12 hours!

@nilp0inter
Copy link
Contributor

@nilp0inter nilp0inter commented Oct 3, 2020

LGTM

@AndersonTorres AndersonTorres merged commit d191ee2 into NixOS:master Oct 3, 2020
19 of 20 checks passed
19 of 20 checks passed
tests tests
Details
action
Details
kapowbang, kapowbang.passthru.tests on x86_64-darwin
Details
kapowbang, kapowbang.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="86e9142"; rev="86e9142dd627de0ea785a7d932b9ce9acd14511f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="86e9142"; rev="86e9142dd627de0ea785a7d932b9ce9acd14511f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="86e9142"; rev="86e9142dd627de0ea785a7d932b9ce9acd14511f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="86e9142"; rev="86e9142dd627de0ea785a7d932b9ce9acd14511f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="86e9142"; rev="86e9142dd627de0ea785a7d932b9ce9acd14511f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="86e9142"; rev="86e9142dd627de0ea785a7d932b9ce9acd14511f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="86e9142"; rev="86e9142dd627de0ea785a7d932b9ce9acd14511f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kapowbang, kapowbang.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.