Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitstatus: also install sh files #99440

Merged
merged 1 commit into from Oct 3, 2020
Merged

gitstatus: also install sh files #99440

merged 1 commit into from Oct 3, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 3, 2020

Motivation for this change

I am developing a shell prompt segment for bash which relies on those files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
etu
etu approved these changes Oct 3, 2020
Copy link
Contributor

@etu etu left a comment

LGTM

Closure size is pretty much unchanged. From 40.1M to 40.1M.

More fine grained it's from 42068576b to 42087800b, thats about 19kb

@etu etu merged commit 755ebd1 into NixOS:master Oct 3, 2020
17 checks passed
@SuperSandro2000 SuperSandro2000 deleted the gitstatus-sh branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants