Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aldo: 0.7.7 -> 0.7.8 #99444

Merged
merged 1 commit into from Oct 28, 2020
Merged

aldo: 0.7.7 -> 0.7.8 #99444

merged 1 commit into from Oct 28, 2020

Conversation

@etu
Copy link
Contributor

@etu etu commented Oct 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@etu etu force-pushed the aldo-upgrade branch from 85904fc to 42a5ddb Oct 3, 2020
Copy link
Contributor

@bennyandresen bennyandresen left a comment

LGTM and builds (and resulting bin runs)

Copy link
Member

@stigtsp stigtsp left a comment

LGTM

Result of nixpkgs-review pr 99444 1

1 package built:
  • aldo

@stigtsp stigtsp merged commit 4512dac into NixOS:master Oct 28, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
aldo, aldo.passthru.tests on x86_64-darwin
Details
@ofborg[bot]
aldo, aldo.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
aldo, aldo.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42a5ddb"; rev="42a5ddbafe8b63491587668490c4a5bd83b6871c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42a5ddb"; rev="42a5ddbafe8b63491587668490c4a5bd83b6871c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42a5ddb"; rev="42a5ddbafe8b63491587668490c4a5bd83b6871c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42a5ddb"; rev="42a5ddbafe8b63491587668490c4a5bd83b6871c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42a5ddb"; rev="42a5ddbafe8b63491587668490c4a5bd83b6871c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42a5ddb"; rev="42a5ddbafe8b63491587668490c4a5bd83b6871c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42a5ddb"; rev="42a5ddbafe8b63491587668490c4a5bd83b6871c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 28, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/265


stdenv.mkDerivation rec {
Copy link
Contributor

@AluisioASG AluisioASG Oct 28, 2020

Was there a particular reason for this change?

Copy link
Contributor Author

@etu etu Oct 28, 2020

I prefer to not have recursive attribute sets where variables can be borrowed and used anywhere, it makes the scope more confusing than a let block :)

Copy link
Contributor

@AluisioASG AluisioASG Oct 28, 2020

Ah, not a style I see often. Thanks for explaining!

@etu etu deleted the aldo-upgrade branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants