Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.crccheck: 0.6 -> 1.0 #99446

Closed
wants to merge 35 commits into from
Closed

Conversation

@etu
Copy link
Contributor

@etu etu commented Oct 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Please fix the merge conflict.

pkgs/development/python-modules/crccheck/default.nix Outdated Show resolved Hide resolved
@etu
Copy link
Contributor Author

@etu etu commented Jan 18, 2021

Rebased on master :)

I had forgot about this PR.

@etu etu force-pushed the python-crccheck-update branch from c31710b to af2a40b Jan 19, 2021
@etu
Copy link
Contributor Author

@etu etu commented Jan 19, 2021

@ofborg eval

@etu etu force-pushed the python-crccheck-update branch 2 times, most recently from af2a40b to 195fc31 Jan 19, 2021
SuperSandro2000 and others added 18 commits Jan 19, 2021
tangram: Use pkg-config instead of pkgconfig
@etu
Copy link
Contributor Author

@etu etu commented Jan 19, 2021

That eval error doesn't look like my fault, rebasing and reevaling.

@ofborg eval

@etu etu closed this Jan 19, 2021
@etu etu mentioned this pull request Jan 19, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants