Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: downgrade Qt to 5.14 #99456

Merged
merged 1 commit into from Oct 4, 2020
Merged

qutebrowser: downgrade Qt to 5.14 #99456

merged 1 commit into from Oct 4, 2020

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 3, 2020

Motivation for this change

There are a number of unresolved issues with Qt 5.15, the most
important one being the inability to properly restore sessions1.
For now it's better to stay at the earlier version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using (qutebrowser)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
There are a number of unresolved issues with Qt 5.15, the most
important one being the inability to properly restore sessions[1].
For now it's better to stay at the earlier version.

[1]: qutebrowser/qutebrowser#5359
@woffs
Copy link
Contributor

@woffs woffs commented Oct 3, 2020

This is related to #97586 2daf570 #98885 and others. I'm fine with 5.15, but as long as qutebrowser has issues with 5.15, it may be better to run under 5.14. This patch works.

woffs
woffs approved these changes Oct 3, 2020
@rnhmjoj rnhmjoj merged commit 0dbce97 into NixOS:master Oct 4, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
qutebrowser, qutebrowser.passthru.tests on x86_64-darwin
Details
@ofborg[bot]
qutebrowser, qutebrowser.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fafb02"; rev="3fafb021256bc594cecd949b3edc5bc480fc721f"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fafb02"; rev="3fafb021256bc594cecd949b3edc5bc480fc721f"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fafb02"; rev="3fafb021256bc594cecd949b3edc5bc480fc721f"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fafb02"; rev="3fafb021256bc594cecd949b3edc5bc480fc721f"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fafb02"; rev="3fafb021256bc594cecd949b3edc5bc480fc721f"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fafb02"; rev="3fafb021256bc594cecd949b3edc5bc480fc721f"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fafb02"; rev="3fafb021256bc594cecd949b3edc5bc480fc721f"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
qutebrowser, qutebrowser.passthru.tests on x86_64-linux Success
Details
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Oct 4, 2020

Backport: 3bef864

@The-Compiler
Copy link
Contributor

@The-Compiler The-Compiler commented Oct 5, 2020

FWIW other than the session support, I think all of those issues are either fixed in Qt 5.15.1 (or .2), or just not relevant outside of qutebrowser development. The only other remaining issue with Qt 5.15.1 are renderer process crashes which can be fixed by backporting this patch: [Backport] Fix for bug 1071327 (Icf418990) · Gerrit Code Review

As for the session support, the choice is between being able to fully restore sessions or having security patches:

  • Qt 5.14.2: Based on Chromium 85.0.4183.83 (~2019-10-10) with security patches up to 80.0.3987.132 (2020-03-03)
  • Qt 5.15.1: Based on Chromium 80.0.3987.163 (2020-04-02) with security patches up to 85.0.4183.83 (2020-08-25)

IMHO, for a web browser, lagging behind more than absolutely necessary with security patches is a bigger problem than not getting back-/forward history after restoring sessions.

@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Oct 5, 2020

Hi, thank you for chiming in. I didn't most of the issue were already resolved, I'll take a look at the patch and consider porting it.

FRidh added a commit to FRidh/nixpkgs that referenced this issue Oct 8, 2020
For security reasons [1] we upgrade to the latest Qt, despite this
breaking a feature, which is why 5.14 was forced earlier.

[1] NixOS#99456 (comment)
@FRidh
Copy link
Member

@FRidh FRidh commented Oct 8, 2020

Intention to "revert" to 5.15 in 902c567 as part of #99956.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 8, 2020

I'm working on a PR to add that patch to our qt5.15

doronbehar added a commit to doronbehar/nixpkgs that referenced this issue Oct 8, 2020
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 8, 2020

qtwebengine PR: #100041

doronbehar added a commit to doronbehar/nixpkgs that referenced this issue Oct 8, 2020
doronbehar added a commit to doronbehar/nixpkgs that referenced this issue Oct 8, 2020
doronbehar added a commit to doronbehar/nixpkgs that referenced this issue Oct 13, 2020
FRidh added a commit to FRidh/nixpkgs that referenced this issue Oct 13, 2020
For security reasons [1] we upgrade to the latest Qt, despite this
breaking a feature, which is why 5.14 was forced earlier.

[1] NixOS#99456 (comment)

(cherry picked from commit 902c567)
gebner added a commit to gebner/nixpkgs that referenced this issue Oct 31, 2020
gebner added a commit to gebner/nixpkgs that referenced this issue Oct 31, 2020
@doronbehar doronbehar mentioned this pull request Nov 5, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants