Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimlsp: init at 0.2.4 #99474

Closed
wants to merge 1 commit into from
Closed

nimlsp: init at 0.2.4 #99474

wants to merge 1 commit into from

Conversation

@nbonfils
Copy link
Contributor

@nbonfils nbonfils commented Oct 3, 2020

Motivation for this change

closes: #99472

Nimlsp is the language server protocol implementation for Nim and was missing from nixpkgs, I think this could benefit Nim beginners to get started since it improves editor support for Nim and ultimately development experience.

This also is my first PR to nixpkgs and was a good exercise, feel free to give me feedback on this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
homepage = "https://github.com/PMunch/nimlsp";
license = licenses.mit;
platforms = platforms.unix;
maintainers = [ maintainers.pmunch ];
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 23, 2020

Suggested change
maintainers = [ maintainers.pmunch ];
maintainers = [ maintainers.nbonfils];

This should be your name not upstream.

sha256 = "1js64jqd854yjladxvnylij4rsz7212k31ks541pqrdzm6hpblbz";
};

nim-src = fetchFromGitHub {
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 23, 2020

Copy link
Member

@ehmry ehmry Oct 23, 2020

Yea, this could be expressed as nim-src = nim.src;.

{ stdenv, fetchFromGitHub, nim, termbox, pcre }:

let
astpatternmatching = fetchFromGitHub {
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 23, 2020

I am not to familiar with nim but should this be an extra package or is this not possible?

Copy link
Member

@ehmry ehmry Oct 23, 2020

This is awkward but fine until we get something like what is done for Go and Rust.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 23, 2020

Friendly ping to @ehmry because he might be able to help out here.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

@nbonfils can you please address the review comments?

@marsam marsam mentioned this pull request Jan 6, 2021
10 tasks
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 6, 2021

Replaced by #108557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants