Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esphome: 1.14.5 -> 1.15.2 #99477

Merged
merged 2 commits into from Oct 3, 2020
Merged

esphome: 1.14.5 -> 1.15.2 #99477

merged 2 commits into from Oct 3, 2020

Conversation

@1000101
Copy link
Member

@1000101 1000101 commented Oct 3, 2020

Motivation for this change

Updates to the latest version and fixes esphome/issues#1402. Also incorporates #98070 updates from @makefu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
makefu and others added 2 commits Oct 3, 2020
upstream switched from setup.py to define the requirements to requirements.txt
@1000101 1000101 requested a review from mweinelt Oct 3, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 3, 2020

Tested an SP111 image, LGTM.

Result of nixpkgs-review pr 99477 1

1 package built:
  • esphome

@mweinelt mweinelt merged commit 6b9bc9e into NixOS:master Oct 3, 2020
2 of 3 checks passed
@mweinelt mweinelt mentioned this pull request Oct 3, 2020
10 tasks
@makefu
Copy link
Contributor

@makefu makefu commented Oct 4, 2020

I was a bit too slow here, thanks for the bump!

@1000101 1000101 deleted the esphome branch Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants