Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.hidapi: fix build on darwin #99478

Merged
merged 1 commit into from Oct 4, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 3, 2020

Motivation for this change

ZHF: #97479

We have no need of this "xcrun" you speak of.

There are still some reverse-dependencies broken on macos that are opened up by the fixing of this. May address separately.

Also add pythonImportsCheck.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
also add pythonImportsCheck
@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 3, 2020

@ofborg build python37Packages.hidapi python38Packages.hidapi

@risicle risicle marked this pull request as ready for review Oct 3, 2020
@risicle risicle requested review from FRidh and jonringer as code owners Oct 3, 2020
@ofborg ofborg bot requested a review from np Oct 3, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 4, 2020

Result of nixpkgs-review pr 99478 1

1 package failed to build:
  • python27Packages.ledgerblue
29 packages built:
  • cm-rgb
  • electron-cash
  • electrum
  • hwi (python38Packages.hwi)
  • keepkey_agent (python38Packages.keepkey_agent)
  • ledger_agent (python38Packages.ledger_agent)
  • plover.stable
  • python27Packages.btchip
  • python27Packages.hidapi
  • python27Packages.python-u2flib-host
  • python37Packages.btchip
  • python37Packages.ckcc-protocol
  • python37Packages.hidapi
  • python37Packages.hwi
  • python37Packages.keepkey
  • python37Packages.keepkey_agent
  • python37Packages.ledger_agent
  • python37Packages.ledgerblue
  • python37Packages.python-u2flib-host
  • python37Packages.trezor
  • python37Packages.trezor_agent
  • python38Packages.btchip
  • python38Packages.ckcc-protocol
  • python38Packages.hidapi
  • python38Packages.keepkey
  • python38Packages.ledgerblue
  • python38Packages.python-u2flib-host
  • python38Packages.trezor
  • trezor_agent (python38Packages.trezor_agent)
@mweinelt mweinelt merged commit 9751fa8 into NixOS:master Oct 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
python37Packages.hidapi, python38Packages.hidapi on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd55969"; rev="bd55969cf971929212dc4b3785dd4d005930a5d9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd55969"; rev="bd55969cf971929212dc4b3785dd4d005930a5d9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd55969"; rev="bd55969cf971929212dc4b3785dd4d005930a5d9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd55969"; rev="bd55969cf971929212dc4b3785dd4d005930a5d9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd55969"; rev="bd55969cf971929212dc4b3785dd4d005930a5d9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd55969"; rev="bd55969cf971929212dc4b3785dd4d005930a5d9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd55969"; rev="bd55969cf971929212dc4b3785dd4d005930a5d9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.hidapi, python38Packages.hidapi on x86_64-linux Success
Details
@risicle risicle mentioned this pull request Oct 4, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.