Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyads: init at 3.2.2 #99479

merged 3 commits into from Oct 3, 2020

pythonPackages.pyads: init at 3.2.2 #99479

merged 3 commits into from Oct 3, 2020


Copy link

@JamieMagee JamieMagee commented Oct 3, 2020

Motivation for this change

ads support for home assistant

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
pkgs/development/libraries/adslib/default.nix Outdated Show resolved Hide resolved
Copy link

@mweinelt mweinelt commented Oct 3, 2020

Result of nixpkgs-review pr 99479 1

3 packages built:
  • adslib
  • python37Packages.pyads
  • python38Packages.pyads

@mweinelt mweinelt merged commit 98d2d8c into NixOS:master Oct 3, 2020
2 of 3 checks passed
@JamieMagee JamieMagee deleted the pyads branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants