Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sawfish: fix build by replacing gdk-pixbuf with gdk-pixbuf-xlib #99483

Merged
merged 1 commit into from Oct 3, 2020

Conversation

@mdevlamynck
Copy link
Contributor

@mdevlamynck mdevlamynck commented Oct 3, 2020

Motivation for this change

Fix build of sawfish.
ZHF: #97479
@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@risicle
Copy link
Contributor

@risicle risicle commented Oct 3, 2020

Builds happily, non-nixos linux x86_64

risicle
risicle approved these changes Oct 3, 2020
Copy link
Member

@AndersonTorres AndersonTorres left a comment

LGTM

@AndersonTorres AndersonTorres merged commit 11d1b7b into NixOS:master Oct 3, 2020
19 checks passed
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 4, 2020

Feel free to backport 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants