Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacsPackages.magit-delta: add git as a build-time dependency #99485

merged 3 commits into from Feb 19, 2021


Copy link

@liff liff commented Oct 3, 2020

Motivation for this change

emacsPackages.magit-delta fails to build:

Searching for program: No such file or directory, git
builder for '/nix/store/p49kg7xj0wxw2psfh1ks33qww2dzcmcs-emacs-magit-delta-20200518.2205.drv' failed with exit code 255
error: build of '/nix/store/p49kg7xj0wxw2psfh1ks33qww2dzcmcs-emacs-magit-delta-20200518.2205.drv' failed

Like many other magit-related packages it wants to find git in PATH at build time.

Things done

Added buildWith and buildWithGit functions to remove some repetitive code that adds build dependencies to Emacs packages. These are in a separate commit.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@adisbladis adisbladis merged commit f583732 into NixOS:master Feb 19, 2021
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants