Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry2nix: fix "invalid Git revision 'master'" #99486

wants to merge 1 commit into from


Copy link

@yihuang yihuang commented Oct 3, 2020

Motivation for this change

When running nix-shell after added a git dependency, it complains invalid Git revision 'master'.
I think it should always prefer resolved_reference to reference?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
- when working with git dependency
@yihuang yihuang changed the title fix "invalid Git revision 'master'" poetry2nix: fix "invalid Git revision 'master'" Oct 4, 2020
Copy link
Contributor Author

@yihuang yihuang commented Oct 4, 2020

opened pr to poetry2nix's own repo.

@yihuang yihuang closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant